From 724d07ef8a4a5150640acdc164d933487bbab9c5 Mon Sep 17 00:00:00 2001 From: Georges Basile Stavracas Neto Date: Sat, 1 Apr 2023 15:33:10 -0300 Subject: [PATCH] gsk/vulkan/image: Use UNDEFINED for initial layout When creating an image using gsk_vulkan_image_new_for_framebuffer(), it passes VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL. However, this is a mistake. The spec demands that the initial layout must be either VK_IMAGE_LAYOUT_UNDEFINED or VK_IMAGE_LAYOUT_PREINITIALIZED. Apparently this was an oversight from commit b97fb751469, since the commit message even documents that, and all other calls pass either VK_IMAGE_LAYOUT_UNDEFINED or VK_IMAGE_LAYOUT_PREINITIALIZED. Create framebuffer images using VK_IMAGE_LAYOUT_UNDEFINED, which is what was originally expected. --- gsk/vulkan/gskvulkanimage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gsk/vulkan/gskvulkanimage.c b/gsk/vulkan/gskvulkanimage.c index b6d4eee548..102d5281bc 100644 --- a/gsk/vulkan/gskvulkanimage.c +++ b/gsk/vulkan/gskvulkanimage.c @@ -575,7 +575,7 @@ gsk_vulkan_image_new_for_framebuffer (GdkVulkanContext *context, height, VK_IMAGE_TILING_OPTIMAL, VK_IMAGE_USAGE_TRANSFER_SRC_BIT | VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT, - VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL, + VK_IMAGE_LAYOUT_UNDEFINED, VK_ACCESS_COLOR_ATTACHMENT_WRITE_BIT, VK_MEMORY_PROPERTY_DEVICE_LOCAL_BIT); -- 2.30.2